-
Notifications
You must be signed in to change notification settings - Fork 0
Text: Update Text Representation #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kergomard,
Thx for looking into this, much appreciated.
I agree with reducing the Markdown* texts and shapes, this underlines we have agreed on keeping the supported syntax close to the original. However, maybe we should take a clear note of this.
I was a bit confused because the section on *Text classes was reduced quite a bit. I think these classes should primarily be used by other components, and only use *Shape classes exceptionally. This change led me to believe otherwise.
In addition to my inline comments below, please
-
SimpleDocumentMarkdownText: there's a reference to this class left in the mail example, which would be removed then. - Make it clear that
*Textclasses are still the main entry point to the system for most of the components. - Add something among the lines of "This is not looking to represent different markdown shapes in a granular manner" to the limitations.
P.S. regarding Latex, I think it would actually be OK to provide a *Text and *Shape class for this, since this is basically another kind of structured text, no? Whereas Mustache is something else entirely.
Kind regards,
@thibsy
| * It may be possible to convert some text available in one representation into some | ||
| other representation but in general it is only expected that every text can be | ||
| converted to HTML and plain text. | ||
| * The facility MUST not interfere with the input of `Moustache` as any input MAY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe reference the mustache specification. Also note the typo =).
| contain `Moustache` placeholders that MUST be passed through unchanged to the | ||
| output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also take note of the "set delimiter" tags, which are i.e. used to wrap latex content according to their manual. This is rather impractical for us, though – dunno if and how much we have to support or consider this.
|
Thank you very much @thibsy for the feedback! I will give the others a little more time to react and will update everything in one fell swoop ;-) . |
Hi all
As promised this is a first try at updating our documentation for text representation. I tried to clarify the structure and I did not yet update the facility in
Data. What it does:Moustachefor the next level of processing. I just added it as a requirement.While working on the feedback concerning the revision of the creation of questions, an additional problem surfaced: MathJax. I do not think this can (and should) be solved on the level of Markup and I do not think
Moustachewill solve the problem for us. My current solution would be to add a similar provision as forMoustache, but maybe somebody has a more elegant proposal.I'm very much looking forward to your feedback.