-
Notifications
You must be signed in to change notification settings - Fork 1
release: 0.8.3 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.8.3 #35
Conversation
|
🧪 Testing To try out this version of the SDK, run: Expires: Sun, 31 Aug 2025 19:26:25 GMT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR generated by release-please to bump the project version to 0.8.3. The release includes one chore commit which adds a .vscode/settings.json file to enforce relative imports for Python. All other file changes are related to updating the version number across the project in files like pyproject.toml, CHANGELOG.md, and src/kernel/_version.py.
Risks / Concerns
This is a very low-risk, automated release. The only change of note is adding a .vscode/settings.json file to standardize import styles, which is a positive change for developer consistency. No concerns with this PR.
6 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
5bd2e4e to
1649d18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR bumping the project version to 0.8.3. The primary change included in this version is the addition of a .vscode/settings.json file to enforce relative Python import formatting, ensuring a consistent coding style for all developers. Consequently, the .gitignore file has been updated to track the .vscode directory.
Risks / Concerns
There are no notable risks in this automated release. The changes focus on improving the developer experience by standardizing settings, which is a positive addition. The release process appears clean and well-managed.
3 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR bumping the version to 0.8.3. The primary change included in this release is the addition of a .vscode/settings.json file to standardize Python import formatting for all developers. This also involved removing .vscode from the .gitignore file. Other changes are related to the version bump across pyproject.toml, CHANGELOG.md, and src/kernel/_version.py.
Risks / Concerns
Looks great! This is a straightforward and low-risk automated release. Adding the VS Code settings to standardize import formatting is a nice touch for improving developer consistency. Well done.
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
4441287 to
79b06da
Compare
d2f355d to
79b06da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This release introduces support for file upload requests. Key changes include:
- The
_build_requestmethod insrc/kernel/_base_client.pyhas been updated to handle rawbytesin the request body, enabling file content to be sent directly. - Helper functions for reading file content in
src/kernel/_files.pyhave been made public (e.g.,_read_file_contentis nowread_file_content) to support this new functionality. - For developer convenience, a VS Code settings file (
.vscode/settings.json) has been added to the project to standardize Python import formatting.
Risks / Concerns
The code changes look solid and introduce valuable new functionality. The only point of concern is a minor discrepancy: the automated changelog in the PR description doesn't mention the new feature for file uploads (feat(client): support file upload requests), which is the most significant change in this release. It's worth ensuring the final release notes are accurate.
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This PR releases version 0.9.0, introducing support for file uploads. The core change is in _base_client.py, where _build_request was updated to handle raw byte data for requests. Additionally, this PR adds a shared .vscode/settings.json to standardize Python import path resolution for all contributors.
Risks / Concerns
This is an automated release PR and the changes look solid. The addition of file upload support is well-contained and the logic in _build_request is straightforward. Great work on adding this valuable feature!
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This automated pull request introduces version 0.9.0 of the SDK. The primary new feature is support for file upload requests, enabled by changes in src/kernel/_base_client.py to handle byte content and by exposing file-reading helpers in src/kernel/_files.py. The update also includes a minor project improvement by adding a VS Code settings file to standardize import path analysis.
Risks / Concerns
This is a straightforward and well-contained automated release. The changes are clear, and the addition of file upload support is a great new feature. No risks have been identified. Well done!
9 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
3073c14 to
6d43e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR for version 0.9.0. The main changes include:
-
File Uploads: A new feature has been added to support file upload requests, primarily through changes in
src/kernel/_base_client.pywhich now handlesbytesas raw requestcontent. -
Default Timeout Reduction: The default HTTP request timeout has been lowered from 60 seconds to 5 seconds across the SDK, as seen in
src/kernel/_constants.pyand theREADME.md. -
Project Tooling: A
settings.jsonfile for VS Code has been added to standardize the development environment.
Risks / Concerns
The primary risk in this release is a potential breaking change. The default request timeout has been significantly reduced from 60 seconds to 5 seconds. Users relying on the previous default for long-running operations will experience timeouts and must update their code to specify a longer timeout explicitly. Otherwise, the changes are well-structured and add valuable new functionality. Great work!
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR for version 0.9.0. It introduces two primary features:
- File Upload Support: The client now supports file upload requests by allowing
bytesto be passed as raw request content in_base_client.py. - Reduced Default Timeout: The default HTTP request timeout has been lowered from 60 seconds to 5 seconds in
src/kernel/_constants.pyto improve default responsiveness.
Additionally, a VS Code settings file was added to standardize project settings for developers.
Risks / Concerns
The most significant change is the reduction of the default request timeout from 60 seconds to 5 seconds. This could be a breaking change for consumers of the SDK who rely on the longer default for slow operations. Otherwise, the changes are straightforward and well-contained for this release.
11 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
Release version edited manuallyThe Pull Request version has been manually set to If you instead want to use the version number |
72dd7e2 to
6d43e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This automated release PR for version 0.8.3 introduces two main features. First, it adds support for file upload requests by enabling the client to handle raw bytes payloads in src/kernel/_base_client.py. Second, it significantly reduces the default API request timeout from 60 seconds to 5 seconds, a change reflected in src/kernel/_constants.py and the README.md. The release also includes minor project improvements, such as adding a VSCode settings file.
Risks / Concerns
There is a potential risk with the new timeout configuration. As noted in the review, the default connect timeout is now the same as the total timeout (5 seconds). This could lead to requests failing if the connection establishment takes the entire allocated time, leaving no time for the actual data transfer. It's recommended to set a shorter connect timeout.
11 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings
src/kernel/_constants.py
Outdated
| # default timeout is 1 minute | ||
| DEFAULT_TIMEOUT = httpx.Timeout(timeout=60, connect=5.0) | ||
| # default timeout is 5 seconds | ||
| DEFAULT_TIMEOUT = httpx.Timeout(timeout=5, connect=5.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The connect timeout (5.0 seconds) is now equal to the overall timeout (5 seconds). This could cause issues since the connect timeout should typically be less than the total timeout to allow time for the actual request/response after connection establishment. Consider reducing the connect timeout to something like 2-3 seconds.
Type: Logic | Severity: Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release for version 0.9.0. The main changes include:
- File Upload Support: The client has been updated to support file upload requests by modifying
_base_client.pyto handlebytescontent. - Reduced Default Timeout: The default timeout for all API requests has been lowered from 60 seconds to 5 seconds in
src/kernel/_constants.py. - Project Tooling: A VS Code settings file was added to enforce relative import formatting for Python code.
Risks / Concerns
The changes in this PR are clear and well-organized. The primary point of attention is the reduction of the default request timeout from 60 seconds to 5 seconds. This is a potentially breaking change for users with long-running requests who will need to explicitly configure a longer timeout after upgrading to avoid unexpected failures.
7 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
49b99b9 to
c6990ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This pull request automates the release of version 0.8.3. Key updates include the introduction of file upload support by enabling _build_request to handle raw bytes content. The default API request timeout has also been lowered to 5 seconds. Additionally, the PR adds a .vscode/settings.json file to standardize the development environment.
Risks / Concerns
This is a well-structured automated release. The only potential consideration is the reduction of the default API timeout to 5 seconds, which could be a breaking change for users who rely on the previous default for long-running operations. Otherwise, the changes are solid and enhance the SDK's capabilities.
5 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Changed
This is an automated release PR that versions the package to 0.8.3. The key changes bundled in this release are:
- File Upload Support: The client now supports file uploads by allowing raw
bytesto be passed as request content insrc/kernel/_base_client.py. - Reduced Default Timeout: The default timeout for API requests has been lowered to 5 seconds.
- Developer Experience: A new
.vscode/settings.jsonfile was added to standardize Python import analysis within the project.
Risks / Concerns
The main consideration with this release is the reduction of the default API timeout to 5 seconds. This could be a breaking change for users performing long-running operations who relied on the previous, more lenient default. Otherwise, this is a great release that adds valuable functionality.
9 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
|
🤖 Release is at https://github.com/onkernel/kernel-python-sdk/releases/tag/v0.8.3 🌻 |
Automated Release PR
0.8.3 (2025-08-01)
Full Changelog: v0.8.2...v0.8.3
Features
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions