Sync Upstream #5
Conversation
* feat: support for entering text indirectly * fix: restore text area value after composition input * update guacamole keyboard. --------- Co-authored-by: fezhang <fezhang@tencent.com> Co-authored-by: Miroslav Šedivý <sedivy.miro@gmail.com>
…ehavior under MacOS Chrome.
* implement new WidevineCdm extraction from crx3. * fix widevinecdm folder. * use m1k1o/go-crx3.
- we don't need to build gstreamer anymore because there is already a quite recent version that supports cuda. - removed not needed apt packages of i386 arch.
* Create pl-pl.ts * Update index.ts * Update client/src/locale/index.ts --------- Co-authored-by: Miroslav Šedivý <sedivy.miro@gmail.com>
![mesa-dot-dev[bot]](https://avatars.githubusercontent.com/in/1050077?s=60&v=4){kind=small}
There was a problem hiding this comment.
Performed full review of 826e0c9...a9d0e9d
Analysis
-
API Compatibility Risk: Significant version bumps (Go 1.21 to 1.24 and WebRTC libraries) require careful validation of API compatibility to ensure no breaking changes are introduced.
-
Testing Gap for IME/Keyboard Changes: The comprehensive overhaul of IME support, while addressing international user issues, introduces complexity that may require additional testing across different platforms and input scenarios.
-
Container Integration Complexity: The refactoring of Widevine CDM installation and dynamic hostname handling in pipelines adds deployment flexibility but increases the operational complexity in containerized environments.
-
Cross-platform Validation Need: Special key handling improvements, particularly for macOS, require verification on all supported platforms to ensure consistent behavior.
Tip
⚡ Quick Actions
This review was generated by Mesa.
Actions:
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
26 files reviewed | 0 comments | Review on Mesa | Edit Reviewer Settings
Noticed some changes to deps + images. Figured it was easier to pull those in than resolve conflicts after #4
TL;DR
Synced the latest changes from the upstream repository, primarily updating dependencies and base images.
Why we made these changes
Noticed some changes to deps + images. Figured it was easier to pull those in than resolve conflicts after #4
What changed?
Dockerfiles to align with the upstream source.Validation
Description generated by Mesa. Update settings