Container limits #1327
Open
Container limits #1327
+337
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved cgroup support, including subgroup delegation. - Drop previously backported patch. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Add resource-limit and resource-usage containers to YANG model. Podman, and later conmon, enforce CPU and memory limits in a delegated cgroupsv2 hierarchy managed by Finit. Resource usage is queried from 'podman inspect', which has more nodes than what is currently possible to limit. Requires Finit 4.15, or later. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
mattiaswal
approved these changes
Dec 18, 2025
Contributor
mattiaswal
left a comment
mattiaswal
left a comment
There was a problem hiding this comment.
Look sine 👍 just a minor comment
| } | ||
| } | ||
|
|
||
| container resource-limit { |
Contributor
Author
There was a problem hiding this comment.
I've checked this now, the indentation of the additions in this file match the rest of this file. Maybe you saw something on in the diff view due to how GitHub displays tabs? This came up in an earlier review too and then I found that GitHub has changed the default from 8 to 4. I've set up my profile to use 8 char tabs: https://github.com/settings/appearance#tab-size-preference
Our YANG files are usually indented with leading spaces (2 per level), and for each 8 spaces they are replaced by a tab character. This is what Emacs yang-mode does.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for configurable CPU and memory limits on containers.
Checklist
Tick relevant boxes, this PR is-a or has-a: