Use styled components to replace Sass #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrodurek
reviewed
Mar 20, 2019
pedrodurek
approved these changes
Mar 22, 2019
Collaborator
|
Just a small thing, but should we apply the same Prettier configs from our project here? The bracketSpacing is true on this project. |
Owner
Author
|
Maybe we could add this prettier config on another PR, the PR #2 is branched out from this one, so it'll may have some conflicts if we do this right now. |
mikelfcosta
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
styled-componentsto replace Sass styles.Note: This PR only replaces the components without too much logic embedded, components that have more logic embedded are still being worked alongside with the tests (e.g. Range selection, range preview)