Skip to content

maint(common): add TC build scripts for keyboards 🪶#3604

Merged
mcdurdin merged 2 commits intomasterfrom
maint/common/14191_tckeyboards
Sep 1, 2025
Merged

maint(common): add TC build scripts for keyboards 🪶#3604
mcdurdin merged 2 commits intomasterfrom
maint/common/14191_tckeyboards

Conversation

@ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Jun 30, 2025

Fixes: keymanapp/keyman#14191
Part-of: keymanapp/keyman#13399
Test-bot: skip

@ermshiperete ermshiperete requested a review from mcdurdin June 30, 2025 16:46
@ermshiperete
Copy link
Contributor Author

I decided to put the scripts for Keyboard builds in the keyboards repo so that we don't have to additionally clone the Keyman repo on TC.

Fixes: #14191
Part-of: #13399
Test-bot: skip
@ermshiperete ermshiperete force-pushed the maint/common/14191_tckeyboards branch from 2dd5f76 to 0dad150 Compare June 30, 2025 16:49
@ermshiperete ermshiperete changed the title maint(common): add TC build scripts for keyboards maint(common): add TC build scripts for keyboards 🪶 Jul 3, 2025
@darcywong00
Copy link
Contributor

Will there be a teamcity script for the build step "Don't allow autobuild of external repo owner PRs"?

@mcdurdin
Copy link
Member

I am holding off on this PR and the corresponding keymanapp/lexical-models#319 until I have found my feet again and other aspects of maintenance are reasonably stable. Hopefully next week.

@mcdurdin
Copy link
Member

Will there be a teamcity script for the build step "Don't allow autobuild of external repo owner PRs"?

This has to stay in TeamCity for security reasons -- or run from a separate protected repo; it can't run from an arbitrary branch.

Comment on lines +20 to +24
"--downloads-keyman-com=DOWNLOADS_KEYMAN_COM_URL URL of downloads server" \
"--help-keyman-com=HELP_KEYMAN_COM Path to help.keyman.com repository" \
"--s-keyman-com=S_KEYMAN_COM Path to s.keyman.com repository" \
"--rsync-path=REMOTE_RSYNC_PATH Path to rsync on remote server" \
"--rsync-dest=RSYNC_DEST Destination for rsync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume these need to be exported so ci.sh can get to them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

function do_publish() {
_upload_to_downloads_keyman_com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should verify that all parameters are set here (as in keymanapp/lexical-models#319 (comment))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +23 to +26
API_URL=$1
URL="https://${API_URL}/_control/webhook/keyboards-build-success.json?token=${WEBHOOK_TOKEN}"
HTTPRESULT=$(curl --silent --write-out "\n\nHTTP status code: %{http_code}" "${URL}")
STATUSCODE=$(echo "${HTTPRESULT}" | tail -n1 | cut -d" " -f 4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
API_URL=$1
URL="https://${API_URL}/_control/webhook/keyboards-build-success.json?token=${WEBHOOK_TOKEN}"
HTTPRESULT=$(curl --silent --write-out "\n\nHTTP status code: %{http_code}" "${URL}")
STATUSCODE=$(echo "${HTTPRESULT}" | tail -n1 | cut -d" " -f 4)
local API_URL="$1"
local URL="https://${API_URL}/_control/webhook/keyboards-build-success.json?token=${WEBHOOK_TOKEN}"
local HTTPRESULT=$(curl --silent --write-out "\n\nHTTP status code: %{http_code}" "${URL}")
local STATUSCODE=$(echo "${HTTPRESULT}" | tail -n1 | cut -d" " -f 4)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mcdurdin mcdurdin merged commit dd3f7d3 into master Sep 1, 2025
2 checks passed
@mcdurdin mcdurdin deleted the maint/common/14191_tckeyboards branch September 1, 2025 05:55
mcdurdin added a commit that referenced this pull request Sep 1, 2025
After merge of #3604, builds failed because we had references to
servervars.sh, a file which is no longer used with the TC scripts
in-repo.

Follows: #3604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maint(common): move logic for Keyboards builds from TeamCity build configuration into repo-based scripts

3 participants