Skip to content

Conversation

@ydroberts
Copy link
Contributor

This is the initial submission of the Geezword Amharic keyboard.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@mcdurdin
Copy link
Member

mcdurdin commented Feb 4, 2026

@ydroberts Hi! Long time no see! Great to see your keyboard coming in here 😁


store(&Version) '17.0' c **************July 9 2024 *******************

store(&KEYBOARDVERSION) '16.0' c August 14 - 20222
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this keyboard version be '18.0' to match your entry in HISTORY.md?

18.0 (10-16-2025)

@darcywong00
Copy link
Contributor

There's several desktop.ini files on this pull request that should be removed. Thanks!

@dyacob
Copy link
Contributor

dyacob commented Feb 6, 2026

The last wave of updates are ready for review. Thanks!

@darcywong00
Copy link
Contributor

Did some of the mobile layout keys get moved?
I installed on my Android device and compared to the geezword-amharic-mobile-*.png screenshots

Default layer

default

The "EAO" keys on the spacebar row look in a different order

Shift layer (shift once)

shift

I noticed some blank keycaps but they still output characters?

@LornaSIL
Copy link
Contributor

Thanks for this keyboard submission! In general the PR is in good shape. However, I always have comments to make the keyboard better.

  • The readme.htm is for the Tigrinya keyboard. It should be updated for Amharic
  • In the .kmn file you can unselect "mobile" as a target since you have "any" selected.
  • If you want people to use a specific font, like Abyssinica SIL, you'll need to add it to the list of files. It's already in the repo at \release\shared\fonts\sil\abyssinica
    • Then, on the Keyboards tab you need to select the Keyboard and Display font.
  • Since this keyboard is under the MIT license, you should not include "All Rights Reserved" since that is contradictory. You should remove that phrase from the .kmn and .kps copyright statements, from the README.md, and any other place I may have missed.

Please also note Darcy's comments above on the mobile layouts.

I think that's it!

@dyacob
Copy link
Contributor

dyacob commented Feb 11, 2026

@darcywong00 good catch with the screenshot. The screenshot had been recycled from the Tigirnya keyboard, but keys did indeed move. It will be updated today.

@LornaSIL the "All Rights Reserved" will be removed. I see that it is present with the Geezword Tigrinya keyboard as well. Should we remove both together in this PR, or do the Tigirnya separately?

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 11, 2026

@LornaSIL the "All Rights Reserved" will be removed. I see that it is present with the Geezword Tigrinya keyboard as well. Should we remove both together in this PR, or do the Tigirnya separately?

Yes, go ahead and make the changes in this PR. Remove "All Rights Reserved" and bump the version in the .kmn and the HISTORY.md. It's possible the copyright years in LICENSE.md will need extending too to include 2026 if it doesn't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants