-
-
Notifications
You must be signed in to change notification settings - Fork 7
docs: add Docker instructions to README.md #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Part of a set of README.md updates for all our major websites. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
| The host machine needs the following apps installed: | ||
| * [Git] | ||
| * Bash 5.x (on Windows, you can use Git Bash that comes with [Git]) | ||
| * [Docker Desktop] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have to be Docker Desktop, or is Docker Engine sufficient on Linux?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess Docker Engine would be sufficient, but have not tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested: works with Docker Engine on Linux.
| **Recommended:** Use [shared-sites] to control startup and shutdown of all | ||
| keyman.com sites together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it say somewhere how to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see - that will be added in keymanapp/shared-sites#82.
| The host machine needs the following apps installed: | ||
| * [Git] | ||
| * Bash 5.x (on Windows, you can use Git Bash that comes with [Git]) | ||
| * [Docker Desktop] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * [Docker Desktop] | |
| * [Docker Desktop] (or Docker Engine on Linux) |
Part of a set of README.md updates for all our major websites.
Test-bot: skip