Merged
Conversation
This adds download statistics collection for Keyman apps hosted on downloads.keyman.com - specifically Keyman for Windows, Keyman for Mac, and Keyman Developer. Other platforms are distributed through stores or other mechanisms, so will not generally be visible here. For now we collect app, version, and tier data, by day. This can be expanded as needed in the future. This is the frontend change; see keymanapp/api.keyman.com#321 for the api backend and database changes. This is implemented as a passthrough redirect on keyman.com. Online updates will not currently appear in these statistics, so the stats against downloads.keyman.com hits will differ. Relates-to: keymanapp/api.keyman.com#321 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
commented
Jan 12, 2026
| # go/app/download | ||
| # | ||
|
|
||
| # download-app?url=... |
Member
Author
There was a problem hiding this comment.
Suggested change
| # download-app?url=... | |
| # go/app/download/<product>/<version>/<tier>?url=https://downloads.keyman.com/... |
mcdurdin
commented
Jan 12, 2026
| * @param bool $trim | ||
| * @return string | ||
| */ | ||
| function GUIDv4 ($trim = true) |
Member
Author
There was a problem hiding this comment.
This function was unused, just noticed when cloning into go/app/download.php
darcywong00
reviewed
Jan 12, 2026
| # | ||
|
|
||
| # download-app?url=... | ||
| RewriteRule "^app/download/([^/?]+)/([^/?]+)/(.*)" "app/download.php?product=$1&version=$2&tier=$3" [END,QSA] |
Contributor
There was a problem hiding this comment.
Is there a url parameter? (download.php l.19)
Member
Author
There was a problem hiding this comment.
QSA means url (and any other query params) will be passed to the rewritten script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds download statistics collection for Keyman apps hosted on downloads.keyman.com - specifically Keyman for Windows, Keyman for Mac, and Keyman Developer. Other platforms are distributed through stores or other mechanisms, so will not generally be visible here.
For now we collect app, version, and tier data, by day. This can be expanded as needed in the future.
This is the frontend change; see keymanapp/api.keyman.com#321 for the api backend and database changes.
This is implemented as a passthrough redirect on keyman.com. Online updates will not currently appear in these statistics, so the stats against downloads.keyman.com hits will differ.
Relates-to: keymanapp/api.keyman.com#321
Test-bot: skip