fix: make section announcement function static#659
Merged
Conversation
Fixes: KEYMAN-COM-321 Fixes: KEYMAN-COM-322 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Feb 12, 2026
Contributor
ermshiperete
left a comment
ermshiperete
left a comment
There was a problem hiding this comment.
LGTM. Why does it have to be static, or why do we want it to be static?
Member
Author
We are just calling it as a static method. We don't need to instantiate the class because it has no data. The class is just wrapping it for simpler namespace-based usage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: KEYMAN-COM-321
Fixes: KEYMAN-COM-322
Test-bot: skip