Skip to content

refactor(web): relocate SearchSpace definition as SearchQuotientSpur, tests to own code file 🚂 #14920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jahorton merged 10 commits into from
Jan 21, 2026
Merged

refactor(web): relocate SearchSpace definition as SearchQuotientSpur, tests to own code file 🚂 #14920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
be473a1
refactor(web): relocate SearchSpace definition, tests to own code file
jahorton Oct 9, 2025
54c76c9
change(web): rename SearchSpace to SearchPath
jahorton Oct 20, 2025
a03601e
change(web): do not relocate PathResult type definitions
jahorton Nov 10, 2025
b1811d9
Merge branch 'refactor/web/correction-heuristic-and-thresholding' int…
jahorton Nov 10, 2025
4940caa
change(web): rename SearchPath as SearchQuotientSpur
jahorton Jan 5, 2026
c02de14
Merge branch 'refactor/web/correction-heuristic-and-thresholding' int…
jahorton Jan 5, 2026
65c8c86
change(web): rename test suite for primary correction-space search me…
jahorton Jan 5, 2026
4d6130e
fix(web): set proper name for test suite
jahorton Jan 5, 2026
0c8851f
docs(web): tweak getBestMatches.tests.ts header comment
jahorton Jan 7, 2026
eba03c3
Merge branch 'docs/web/add-search-space-doc' into refactor/web/reloca…
jahorton Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web/src/engine/predictive-text/worker-thread/src/main/correction/context-token.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { applyTransform, buildMergedTransform } from "@keymanapp/models-template
import { LexicalModelTypes } from '@keymanapp/common-types';
import { deepCopy, KMWString } from "@keymanapp/web-utils";

import { SearchSpace } from "./distance-modeler.js";
import { SearchQuotientSpur } from "./search-quotient-spur.js";
import { TokenSplitMap } from "./context-tokenization.js";

import Distribution = LexicalModelTypes.Distribution;
Expand Down Expand Up @@ -58,7 +58,7 @@ export class ContextToken {
* Contains all relevant correction-search data for use in generating
* corrections for this ContextToken instance.
*/
readonly searchSpace: SearchSpace;
readonly searchSpace: SearchQuotientSpur;
Copy link
Contributor Author

@jahorton jahorton Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: determine a better property name. Long-term, per #15161, this should reflect the SearchQuotientNode (previously, SearchSpace) module handler matching the token.

Perhaps searchGraphModule?


isPartial: boolean;

Expand Down Expand Up @@ -104,7 +104,7 @@ export class ContextToken {
//
// In case we are unable to perfectly track context (say, due to multitaps)
// we need to ensure that only fully-utilized keystrokes are considered.
this.searchSpace = new SearchSpace(priorToken.searchSpace);
this.searchSpace = new SearchQuotientSpur(priorToken.searchSpace);
this._inputRange = priorToken._inputRange.slice();

// Preserve any annotated applied-suggestion transition ID data; it's useful
Expand All @@ -118,7 +118,7 @@ export class ContextToken {
// May be altered outside of the constructor.
this.isWhitespace = false;
this.isPartial = !!isPartial;
this.searchSpace = new SearchSpace(model);
this.searchSpace = new SearchQuotientSpur(model);
this._inputRange = [];

rawText ||= '';
Expand Down
Loading