change(web): utilize and track multiple potential tokenizations of user input 🚂 #15222
+551
−429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
web/
web/predictive-text/
change
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/realign-tokenization
branch
from
49391d5 to
3473c6f
Compare
jahorton
force-pushed
the
change/web/start-multi-tokenization
branch
from
dead790 to
e7e019d
Compare
jahorton
force-pushed
the
refactor/web/realign-tokenization
branch
from
3473c6f to
4f257f5
Compare
…er input We've now reached a point where we can finally begin to consider word-boundary correction. This could occur due to different causes: 1. Whitespace fat-fingering - either by correcting to a whitespace key or away from it 2. epic/dict-breaker: word boundaries are far more ambiguous for its target languages Eventually... 3. Autocorrection _due_ to the user fat-fingering onto a key that triggers autocorrection. As it wasn't directly and manually triggered, we should consider correcting the suggestion's acceptance, undoing it and correcting differently if later input merits it. Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
change/web/start-multi-tokenization
branch
from
e7e019d to
3c2b0bf
Compare
jahorton
changed the base branch from
refactor/web/realign-tokenization
to
feat/web/specialized-spurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've now reached a point where we can finally begin to consider word-boundary correction. This could occur due to different causes:
Eventually...
3. Autocorrection due to the user fat-fingering onto a key that triggers autocorrection. As it wasn't directly and manually triggered, we should consider correcting the suggestion's acceptance, undoing it and correcting differently if later input merits it.
TODO: add specialized unit tests for the newly-supported pathways
Build-bot: skip build:web
Test-bot: skip