-
-
Notifications
You must be signed in to change notification settings - Fork 133
change(web): add .edgeKey for use + validation of complex .split cases 🚂 #15508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jahorton
wants to merge
2
commits into
refactor/web/complex-search-space-reuse
Choose a base branch
from
feat/web/spur-edge-key
base: refactor/web/complex-search-space-reuse
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
change(web): add .edgeKey for use + validation of complex .split cases 🚂 #15508
jahorton
wants to merge
2
commits into
refactor/web/complex-search-space-reuse
from
feat/web/spur-edge-key
+81
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
0c4a793 to
92546fa
Compare
0c4e15a to
bd5e4d9
Compare
92546fa to
240b1f6
Compare
bd5e4d9 to
7e1b6f4
Compare
240b1f6 to
76b3479
Compare
7e1b6f4 to
d3857a1
Compare
Build-bot: skip build Test-bot: skip
76b3479 to
2127072
Compare
mcdurdin
approved these changes
Feb 5, 2026
Member
mcdurdin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, currently only used for unit tests?
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When splitting
SearchQuotientClusterinstances, things can get a bit complex. "Later" instances are constructed recursively from "earlier" instances, and it's not in a tree-like fashion - there can easily be a directed graph leading form the search root to any given instance, with converging and diverging quotient-paths. If a split occurs during a "divergent" section, we need a strategy to faciltate de-duplication of split sections..edgeKeyis that tool.It also provides a useful component of determining when two nodes may be considered "duplicates" of each other, something that can be very useful for unit-test assertions.
Build-bot: skip build
Test-bot: skip