Skip to content

Conversation

@ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Feb 9, 2026

Under some circumstances it's possible that the user manages to select a directory instead of a kmp file, or manually enters a non-existing file. Is used to throw an error that we caught on Sentry; the user was able to continue to use the app. This change now checks for a valid file before trying to install the kmp file.

Fixes: #15572
Fixes: KEYMAN-LINUX-99

User Testing

TEST_FIX:

  • start km-config and click the "Install keyboard" button
  • in the "Choose a kmp file" dialog press Ctrl+L to get an input field
  • enter an invalid path, e.g. /homex, and click Open
  • verify that the file dialog stays open until you enter or select a valid file or cancel the dialog

@github-project-automation github-project-automation bot moved this to Todo in Keyman Feb 9, 2026
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Feb 9, 2026
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Feb 9, 2026

User Test Results

Test specification and instructions

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S22 milestone Feb 9, 2026
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Feb 9, 2026
@ermshiperete ermshiperete marked this pull request as draft February 9, 2026 14:58
Under some circumstances it's possible that the user manages to select
a directory instead of a kmp file, or manually enters a non-existing file.
Is used to throw an error that we caught on Sentry; the user was able to
continue to use the app. This change now checks for a valid file before
trying to install the kmp file.

Fixes: #15572
Fixes: KEYMAN-LINUX-99
@ermshiperete ermshiperete force-pushed the fix/linux/15572_FileNotFoundError branch from ef8990c to 7941b3d Compare February 9, 2026 15:04
@ermshiperete ermshiperete marked this pull request as ready for review February 9, 2026 15:05
@Meng-Heng Meng-Heng self-assigned this Feb 11, 2026
@Meng-Heng
Copy link
Contributor

Test Prerequisites

  1. Ensure Keyman for Linux is on the right version by using km-package-list-installed --version in Terminal

Test Specs

  1. macOS Intel, Virtual Box
  2. Ubuntu Noble
  3. km-package-list-installed version 19.0.201-alpha (package version 19.0.201-1~PR-15573)

Test Results

  • TEST_FIX (PASSED):
  1. In the Terminal, type km-config
  2. In Keyman Configuration, click "Install keyboard"
  3. In "Choose a kmp file", press CTRL + L to enter the input field
  4. Enter /homex, click "Open"
  5. Verify: The dialog remains open until clicking on a folder.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Feb 12, 2026
@Meng-Heng Meng-Heng removed their assignment Feb 12, 2026
@ermshiperete ermshiperete merged commit d32d1b6 into master Feb 12, 2026
10 checks passed
@ermshiperete ermshiperete deleted the fix/linux/15572_FileNotFoundError branch February 12, 2026 09:20
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug(linux): FileNotFoundError: [Errno 2] No such file or directory

3 participants