chore: merge master into feature-ldml #7104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picked up while reviewing code for conversion to C++. The compiler could, in some circumstances emit garbage code for readonly groups because we weren't testing all scenarios correctly. In practice, this would have been rare as readonly groups don't emit characters, but it should be fixed!
Fixes #7030. Prevents a stack overflow / loop when the web target is removed from a keyboard and it has already been tested on web, and the user presses the Compile button.
(cherry picked from commit cbb9e65)
…elog chore(linux): Update debian changelog 🍒
auto: increment master version to 16.0.45
…cated-distutils feat(linux): Replace deprecated distutils
chore(linux): Adjust Linux source package to restructured code
auto: increment master version to 16.0.46
- use standard Keyman include scripts - remove package build support for legacy projects - install dependencies from `debian/control` file instead of maintaining a separate list
- fixes to api doc
docs(core): cleanup in keyboardprocessor.h
auto: increment master version to 16.0.50
chore(core): Remove obsolete python keyboardprocessor
mcdurdin
requested review from
darcywong00,
ermshiperete,
jahorton,
rc-swag and
sgschantz
as code owners
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
common/
common/core/
common/web/
developer/
linux/
linux/config/
linux/engine/
chore
labels
mcdurdin
requested review from
srl295
and removed request for
darcywong00,
ermshiperete,
jahorton,
rc-swag and
sgschantz
srl295
approved these changes
Aug 23, 2022
Member
srl295
left a comment
srl295
left a comment
There was a problem hiding this comment.
RSLGTM. I can see all but the merge commit are previously built.
Member
|
I note that
was still failing on the penultimate commit merged ,but it seems that is a flaky or timeout issue |
Member
Author
Yeah, because @jahorton still hasn't merged #7037. We'll have to do another master merge once that comes through. I don't want to merge it myself because unsure if he has anything he wants to do on it first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip