Initial submission of Chadian Arabic predictive keyboard#157
Initial submission of Chadian Arabic predictive keyboard#157jeffheath-sil wants to merge 1 commit intokeymanapp:masterfrom
Conversation
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
|
Generally looks pretty good, just a few changes (plus some suggestions): Delete source/wordlist.tsv since this file (created by the New Project wizard) is not used In the LICENSE.md file, could you change "SIL" to "SIL International" in the copyright statement (and any other copyright statements you keep, but see below) In the README.md, could you change the description, even if it's just: "Lexical model for Chadian Arabic". sil.shu-latn.chadian_arabic.model_info: change description as for README.md Suggestions: We now require only the LICENSE.md file to have a copyright statement with the date and the name of the copyright holder. Any other copyright statement can have only the name, BUT other copyright statements are optional. (This reduces the number of files that need to change for the next version.) I'd suggest that you:
One other comment: I was a little surprised to see no frequency count with Paratext word list. Is that intentional? |
|
@jeffheath-sil No pressure, but just want to make sure you don't need anything from me in order to proceed. |
|
@jeffheath-sil Just checking on status. |
|
@jeffheath-sil Checking on status |
Based on 3 source word lists