-
-
Notifications
You must be signed in to change notification settings - Fork 42
Update Shavian_Info en-Shaw ReadLex lexical model #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added new spellings and brought existing spellings into line with the current Kingsley Read Lexicon.
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
This PR is in good shape. There are a few small changes (some of which will help make future updates easier) and one question. The LICENSE.md file needs updating:
In the README.md file, please
In the welcome.htm file, please
In the .model.ts file ("Details" tab, comments field)
In the .kps file ("Details" tab)
I also note that the wordlist.tsv file has 8000+ words at the end with frequency count of zero. I've asked the developers what happens with these words. Do they get ignored? or given a count of "1"? or something else? What was your intent with the zero count? Thanks! |
|
The word frequencies are taken from the British National Corpus. A frequency of zero means the word doesn't appear in the BNC. This may be because the word is newer than the corpus (a lot of online terms post-date the BNC) or for some reason didn't appear in the extensive source material. I expected them simply to appear as the last option in any list of words. I can give them all a frequency of 1 if that works better for Keyman. I'll fix those other issues you mention. |
|
It turns out that the compiler includes words with zero counts as having no weighting, which ends up being below a weight of "1", which is exactly what you expected. |
|
I should have now addressed all of the issues identified in #318 (comment) |
DavidLRowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
Added new spellings and brought existing spellings into line with the current Kingsley Read Lexicon.