Skip to content

fix: include missing parameter for rsync_to_downloads_keyman_com call #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcdurdin merged 1 commit into from
Aug 29, 2025
Merged

fix: include missing parameter for rsync_to_downloads_keyman_com call #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ fi

. "$MODELROOT/servervars.sh"
. "$MODELROOT/resources/util.inc.sh"
. "$MODELROOT/resources/rsync-tools.sh"
. "$MODELROOT/resources/rsync-tools.inc.sh"

function run {

Expand All @@ -50,7 +50,7 @@ function run {
upload_models_by_target

zip_model_info
rsync_to_downloads_keyman_com "$CI_CACHE/data/" data/
rsync_to_downloads_keyman_com "$CI_CACHE/data/" data/ false
Copy link
Contributor

@darcywong00 darcywong00 Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include about comment about the false parameter? (not applying --ignore-existing)

Copy link
Member Author

@mcdurdin mcdurdin Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will apply that another day -- because we have the same issue for the true parameter in the other call. It's easy enough to look at the function to find out what it means.

}

##
Expand Down
3 changes: 2 additions & 1 deletion resources/rsync-tools.sh → resources/rsync-tools.inc.sh
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/bin/bash
# shellcheck shell=bash
# Keyman is copyright (C) SIL Global. MIT License.

##
## Use rsync to upload new files from a folder
Expand Down