GFF Amharic lexical model v1.1.1#328
Merged
LornaSIL merged 2 commits intokeymanapp:masterfrom Sep 8, 2025
Merged
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
darcywong00
requested changes
Sep 8, 2025
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
You'll also need to increment the version in
(Can change it from Keyman Developer)
Contributor
Author
|
Thank you @darcywong00 , my last commit fixes the version number in the .kps file Also the copyright year range in the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change for the frequency of entry of "ነዉ", which was artificially high due to a common typing error of the appropriate word "ነው". The consequence has been "ነዉ" appearing as a top-level suggestion when it shouldn't be for a seldom-used word.
The frequency counts subtracted from "ነዉ" could be added to the intended word "ነው". I have not done so, but can if advised to do so. "ነው" is still the most frequently used word, so adding the difference shouldn't change its ranking.