fix: Fail build if curl of cached file fails#339
Merged
darcywong00 merged 2 commits intokeymanapp:masterfrom Feb 5, 2026
Merged
fix: Fail build if curl of cached file fails#339darcywong00 merged 2 commits intokeymanapp:masterfrom
darcywong00 merged 2 commits intokeymanapp:masterfrom
Conversation
darcywong00
commented
Feb 5, 2026
| local version=`curl "$query" | $JQ -r '.[].version'` | ||
| local model_info_filename="https://downloads.keyman.com/models/${model_id}/${version}/${model_id}.model_info" | ||
| curl -s -L "$model_info_filename" --output "$model_id.model_info" --create-dirs || die "Unable to download $model_info_filename" | ||
| curl -s -L -f "$model_info_filename" --output "$filename" --create-dirs || builder_die "Unable to download $model_info_filename" |
Contributor
Author
There was a problem hiding this comment.
$filename = $model_id.model_info
But keeping consistent with the other files
mcdurdin
approved these changes
Feb 5, 2026
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
Only question is, wouldn't it have failed soon after on the checksum anyway?
mcdurdin
reviewed
Feb 5, 2026
Contributor
Author
Yeah, that would have flagged it too |
Co-authored-by: Marc Durdin <marc@durdin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #337 on caching files from downloads.keyman if external source is not available
-f(--fail) flag to curl command to fail the buildTest-bot: skip