Skip to content

feat: Pass builder configuration to Docker build step #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darcywong00 merged 1 commit into from
Nov 26, 2025
Merged

feat: Pass builder configuration to Docker build step #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion _common/docker.inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,15 @@ function _verify_vendor_is_not_folder() {
function build_docker_container() {
local IMAGE_NAME=$1
local CONTAINER_NAME=$2
local BUILDER_CONFIGURATION="release"
if [[ $# -eq 3 ]]; then
BUILDER_CONFIGURATION=$3
fi

_verify_vendor_is_not_folder

# Download docker image. --mount option requires BuildKit
DOCKER_BUILDKIT=1 docker build -t $IMAGE_NAME .
DOCKER_BUILDKIT=1 docker build -t $IMAGE_NAME --build-arg BUILDER_CONFIGURATION="${BUILDER_CONFIGURATION}" .
}

function start_docker_container() {
Expand Down