maint: angular 21 upgrade #592
Conversation
Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
ah, already merged.
platform.value was the only real question I had
| @if (user.login != '') { | ||
| <span class="summary-label">Issues <a href="https://github.com/search?q=org%3Akeymanapp+assignee%3A{{user.login}}+milestone%3A{{status.currentSprint?.title}}+is%3Aopen&type=issues" target="_blank">assigned</a> to <a href="https://github.com/{{user.login}}" target="_blank">@{{user.login}}</a> in {{status.currentSprint?.title}}</span> | ||
| } | ||
| @if (user.login == '') { |
There was a problem hiding this comment.
Does else work?
| @if (user.login == '') { | |
| @else { |
| @@ -1 +1,5 @@ | |||
| <span (click)="copyToClipboard()" title="{{title}}"><ng-container *ngIf="!loading">📋</ng-container><span *ngIf="loading" class="spinner-border spinner-border-sm"></span></span> | |||
| <span (click)="copyToClipboard()" title="{{title}}">@if (!loading) { | |||
There was a problem hiding this comment.
Do you want @if (!loading) { on a separate line for coding tyle?
| <app-pull-request [status]="status" [changeCounter]="changeCounter" [teamCity]="status.teamCity" [scope]="'platform'" [scopeValue]="platform.value.id" [gravityX]="'left'" [gravityY]="'bottom'" [pull]="pull"></app-pull-request> | ||
| </span> | ||
| </div> | ||
| @for (emoji of platform.pullsByEmoji | keyvalue; track emoji.key) { |
There was a problem hiding this comment.
Throughout the PR I see platform.value is now just platform.
Yeah, that was a change made by the way loops are now done with |
2 participants
Test-bot: skip