-
Notifications
You must be signed in to change notification settings - Fork 0
feat: dockerize the site #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
Note: this removes the non-docker configuration, to reduce maintenance. Development version runs in two containers in order to simplify live-reload. Production version will run in a single container. See README.md for details of usage. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
|
Not directly related to this PR but triggered by it: I only skimmed over the changes and realized that I'm not clear how it's split up in two containers. Looking at the existing documentation I get an idea how it's probably done. I think at some point we should improve the readme and add a few sentences explaining what we understand here as server and client (server=backend running on the server, client=frontend running in the browser?) and which directories implement that (I guess since there is a |
| } | ||
|
|
||
| function stop_docker_containers() { | ||
| rm -f ./_control/ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't this be in clean_docker_containers?
|
If we want to use status.keyman.com.localhost for local dev, https://github.com/keymanapp/website-local-proxy/blob/master/resources/nginx.conf |
For now, as we need to keep the deployment to Azure working, update the workflows to use the new script locations. Test first on staging.
|
Note: I have changed base to staging (https://com-keyman-staging-status.azurewebsites.net/) while we test this, to make sure that the deployment doesn't break the main status.keyman.com site. I will follow up with a production PR once we are confident that the azure deployment still works. |
Note: this removes the non-docker configuration, to reduce maintenance.
Development version runs in two containers in order to simplify live-reload. Production version will run in a single container.
See README.md for details of usage.
Test-bot: skip