Skip to content

feat: search in more than one namespace#200

Open
matheusandre1 wants to merge 2 commits intokgrep-org:mainfrom
matheusandre1:issue18
Open

feat: search in more than one namespace#200
matheusandre1 wants to merge 2 commits intokgrep-org:mainfrom
matheusandre1:issue18

Conversation

@matheusandre1
Copy link

Closes: #18

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for searching logs across multiple Kubernetes namespaces by allowing the --namespace/-n flag to accept a comma-separated list.

Changes:

  • Update logs command to split --namespace into multiple namespaces and aggregate results.
  • Export Grepper.SortMessages and use it to re-sort combined results across namespaces.
  • Add/adjust tests for the new sort method and multi-namespace flag parsing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
cmd/logs.go Split comma-separated namespaces, loop over them, aggregate results, and re-sort when multiple namespaces are provided.
internal/log/log_grepper.go Export SortMessages (was sortMessages) and update Grep to call it.
internal/log/log_grepper_test.go Update existing sort test to use SortMessages and add a new test covering sort modes.
cmd/cmd_test.go Add a CLI test intended to validate multi-namespace flag syntax.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… and REFACTOR and Sort Messages simplifying with slices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to search in more than one namespace

2 participants