feat: search in more than one namespace#200
Open
matheusandre1 wants to merge 2 commits intokgrep-org:mainfrom
Open
feat: search in more than one namespace#200matheusandre1 wants to merge 2 commits intokgrep-org:mainfrom
matheusandre1 wants to merge 2 commits intokgrep-org:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for searching logs across multiple Kubernetes namespaces by allowing the --namespace/-n flag to accept a comma-separated list.
Changes:
- Update
logscommand to split--namespaceinto multiple namespaces and aggregate results. - Export
Grepper.SortMessagesand use it to re-sort combined results across namespaces. - Add/adjust tests for the new sort method and multi-namespace flag parsing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
cmd/logs.go |
Split comma-separated namespaces, loop over them, aggregate results, and re-sort when multiple namespaces are provided. |
internal/log/log_grepper.go |
Export SortMessages (was sortMessages) and update Grep to call it. |
internal/log/log_grepper_test.go |
Update existing sort test to use SortMessages and add a new test covering sort modes. |
cmd/cmd_test.go |
Add a CLI test intended to validate multi-namespace flag syntax. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… and REFACTOR and Sort Messages simplifying with slices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #18