Add NuGet packaging and GitHub Packages upload to CI #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three new steps to the CI workflow: 1. Pack NuGet package: - Builds Release configuration of Scrutor.csproj - Outputs to ./artifacts directory - Creates deterministic .nupkg and .snupkg files 2. Upload NuGet package artifact: - Makes packages available as GitHub Actions artifacts - Useful for debugging and manual downloads - Preserved for workflow retention period 3. Push to GitHub Packages: - Only runs on push events (not pull requests) - Only runs on khellang/* repositories - Uses GITHUB_TOKEN for authentication - Skips duplicates to avoid errors on re-runs - Publishes to GitHub's NuGet feed This enables automatic package distribution on every push while maintaining deterministic, reproducible builds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
===========================================
+ Coverage 64.71% 86.31% +21.60%
===========================================
Files 25 29 +4
Lines 1278 2053 +775
Branches 0 247 +247
===========================================
+ Hits 827 1772 +945
+ Misses 451 250 -201
- Partials 0 31 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
khellang
deleted the
claude/upgrade-to-dotnet-01HBTW8qPH6GH7H2tV8LnYVo
branch
There was a problem hiding this comment.
Pull request overview
This PR adds automated NuGet package creation and publishing to the CI workflow. It enables packages to be built on every workflow run, uploaded as artifacts for manual access, and automatically published to GitHub Packages when code is pushed to the main repository.
Key Changes:
- NuGet package creation in Release configuration with output to
./artifacts - Artifact upload to GitHub Actions for debugging and manual downloads
- Conditional publishing to GitHub Packages for push events on khellang/* repositories
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: nuget-packages | ||
| path: ./artifacts/*.nupkg |
There was a problem hiding this comment.
The artifact upload path pattern ./artifacts/*.nupkg only matches .nupkg files but not .snupkg (symbol package) files. According to the PR description, both .nupkg and .snupkg files are created. Consider using ./artifacts/*.*nupkg or ./artifacts/** to include both package types in the artifact upload.
Suggested change
| path: ./artifacts/*.nupkg | |
| path: ./artifacts/*.*nupkg |
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
Closed
This was referenced Dec 14, 2025
This was referenced Dec 24, 2025
This was referenced Jan 1, 2026
This was referenced Jan 25, 2026
github-merge-queue bot
pushed a commit
to DFE-Digital/teaching-record-system
that referenced
this pull request
Jan 29, 2026
Updated [Scrutor](https://github.com/khellang/Scrutor) from 6.1.0 to 7.0.0. <details> <summary>Release notes</summary> _Sourced from [Scrutor's releases](https://github.com/khellang/Scrutor/releases)._ ## 7.0.0 ## What's Changed * Add Sponsors section to README by @khellang in khellang/Scrutor#255 * Update to .NET 10 by @khellang in khellang/Scrutor#265 * Add NuGet packaging and GitHub Packages upload to CI by @khellang in khellang/Scrutor#266 * Use MinVer for versioning by @khellang in khellang/Scrutor#267 * Add support for service key registration by @mokarchi in khellang/Scrutor#262 * Add support for exposing decorated services by @adamjones2 in khellang/Scrutor#261 * Add keyed service registration support by @A-Ebrahimzadeh-dev in khellang/Scrutor#260 ## New Contributors * @mokarchi made their first contribution in khellang/Scrutor#262 * @adamjones2 made their first contribution in khellang/Scrutor#261 * @A-Ebrahimzadeh-dev made their first contribution in khellang/Scrutor#260 **Full Changelog**: khellang/Scrutor@v6.1.0...v7.0.0 Commits viewable in [compare view](khellang/Scrutor@v6.1.0...v7.0.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Gunn <james@gunn.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add three new steps to the CI workflow:
Pack NuGet package:
Upload NuGet package artifact:
Push to GitHub Packages:
This enables automatic package distribution on every push while maintaining deterministic, reproducible builds.