Open
Conversation
Owner
|
Thanks for this PR and apologies for the time it took for me to respond. I will review soon. |
kiddouk
reviewed
Feb 9, 2018
|
|
||
| static gpgme_error_t passphrase_cb (void *opaque, const char *uid_hint, const char *passphrase_info, int last_was_bad, int fd) { | ||
| int res; | ||
| char pass[255]; |
Owner
There was a problem hiding this comment.
I fear a nice buffer overflow here.
Author
There was a problem hiding this comment.
Hmm makes sense, its copying from opaque but not checking the length. I will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a function to sign data using a private key. It works, but I got bit disapointed since its faster calling shell exec with gpg2 than using this wrapper :( (50ms on gpg2 vs 350ms through this wrapper)
Still, thats a good info since it can be used for decrypt stuff as well.