Skip to content

added an extra clean up method after deletion of object #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IAlwaysBeCoding wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added an extra clean up method after deletion of object #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d988d66
added an extra clean up method after deletion of object
Jul 17, 2015
7440bbf
added an extra clean up method after deletion of object
Jul 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion redisco/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,6 @@ def key(self, att=None):
return self._key[self.id][att]
else:
return self._key[self.id]

def delete(self):
"""Deletes the object from the datastore."""
pipeline = self.db.pipeline()
Expand All @@ -352,6 +351,16 @@ def delete(self):
pipeline.delete(self.key())
pipeline.execute()

#Clean up procedure used for cleaning up {ModelName}:id
#when there are no objects left inside {ModelName}:all.
#This only occurs when all the objects have been deleted.
#So,{ModelName}:id is left with the the last total count """

any_left = redisco.get_client().hexists(name=self._key,key=self._key['all'])
if not any_left:
pipeline.delete(self._key['id'])
pipeline.execute()

def is_new(self):
"""
Returns True if the instance is new.
Expand Down