#145 - Register HealthCheckRegistry#180
Merged
sbrossie merged 3 commits intokillbill:masterfrom Jun 6, 2025
Merged
Conversation
Member
|
What do you see when you print the names here ? |
Contributor
Author
This is what I see: |
sbrossie
reviewed
May 30, 2025
Member
sbrossie
left a comment
There was a problem hiding this comment.
Don't we need to also make this service available from the KillbillActivatorBase - if not do we expect, plugins to use ServiceTracker apis to fetch the OCGI bundle?
Contributor
Author
Made changes in the code to make the |
sbrossie
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work for #145.
Edit: 2025-05-28: I did some more investigations and I think the system works as expected. See this comment.
I've tested this from the hello-world-plugin. See this PR. So, I can access KB healthcheck and plugins healthcheck from thehello-world-plugin. However, I'm unable to check the health of an individual plugin like Aviate. (See this line).So a few questions:Do the changes in this PR look good?Is the testing approach correct?Should we be able to access healthcheck for an individual plugin likeAviatelike done here?