Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So after I already wrote all this code, I noticed there were a couple other pull requests. Oh well. Decided to put it in anyway, why not - maybe you guys can use some pieces of it.
The conversion here is clean and very similar to the original jquery code. One thing I did not do at all was test in old IE. I did mark a couple spots in the script where older IE versions are likely to have issues. These could probably be fixed pretty quickly by replacing them with a function that does a quick test and if/else statement. Maybe I'll do this sometime in the future, but it seems like there may be enough pull requests here already haha.
Cheers!