Skip to content

Conversation

@maximiliani
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 4, 2025 12:43
@maximiliani maximiliani merged commit b55e297 into main Dec 4, 2025
7 checks passed
@maximiliani maximiliani deleted the maximiliani-patch-1 branch December 4, 2025 12:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the base request mapping for the PidRedirectController from "/" to "/pid/", effectively moving all PID redirect endpoints under a /pid/ prefix. This change addresses the overly broad root path mapping and provides better API organization.

Key Changes:

  • Modified @RequestMapping annotation from "/" to "/pid/" on PidRedirectController class
  • The redirect endpoint moves from /{pidValue} to /pid/{pidValue}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


@Controller
@RequestMapping("/")
@RequestMapping("/pid/")
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change modifies the base path from "/" to "/pid/", which is a breaking API change. The endpoint that was previously accessible at /{pidValue} will now be accessible at /pid/{pidValue}.

This will break existing clients that are using the old endpoint. Consider:

  1. Adding a deprecation period with both endpoints supported
  2. Documenting this breaking change in release notes
  3. Communicating with API consumers about the migration

Alternatively, if the old "/" mapping was too broad and conflicted with other routes, consider if this is the intended behavior.

Copilot uses AI. Check for mistakes.

@Controller
@RequestMapping("/")
@RequestMapping("/pid/")
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This endpoint path change lacks test coverage. There are no existing tests for PidRedirectController, and this breaking change should be validated with tests to ensure:

  1. The new /pid/{pidValue} endpoint works correctly
  2. The redirect logic continues to function as expected
  3. Different entity types (AtomicDataType, Attribute, Operation, TechnologyInterface, TypeProfile) are redirected properly

Consider adding integration tests for this controller to prevent regressions and validate the new routing behavior.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants