feat(live-loans): retry borrower image loading or use fallback without caching MP-2268 #6459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emuvente
changed the title
mcstover
approved these changes
Nov 19, 2025
dyersituations
approved these changes
Nov 19, 2025
Collaborator
dyersituations
left a comment
dyersituations
left a comment
There was a problem hiding this comment.
Thanks much for the quick fix! Makes sense to start with 2 retries.
Collaborator
|
🎉 This PR is included in version 3.45.0-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 3.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live loan cards are missing the borrower photo in some cases. We get an error message,
Error loading image: Error: Server responded with undefined, but there's a bug in canvas that prevents us from seeing the http status code. It's been fixed, but the fix has not been published.Whatever the request issue is, we should have a better user experience than a loan card with a blank white space where the image should be. This PR adds retries for failed image loading requests, a fallback image for when the retries fail too, more verbose error logging so we can start to track down the cause of the image loading failures, and this prevents the loan card image from being cached if the borrower image failed to load.
Live loan cards with the fallback image:
