no-release(fix): no-release in CI
#19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the CI workflow to prevent unwanted releases when commit messages start with no-release followed by a type in parentheses (e.g., no-release(deps):, no-release(fix):). Previously, only commits starting with no-release: (with a colon) would skip the release process, causing commits like no-release(deps): to trigger releases unintentionally.
Changes:
- Updated the release job condition to check for
no-releaseprefix instead ofno-release:prefix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Conventional Commits also allows for e.g. no-release(<reason>): and we wanna account for that without making this over-complicated
kivra-pauoli
force-pushed
the
fix/no-release
branch
from
80c67bf to
46f594d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Have no releases for
no-release(fix): ..., for example.Description
I recently merged with a message like
no-release(deps): ...and this created an unwarranted release. This PR fixes that.