Support stacktrace sending when stack_info is enabled (#87)#158
Open
devonwarren wants to merge 2 commits intokiwicom:masterfrom
Open
Support stacktrace sending when stack_info is enabled (#87)#158devonwarren wants to merge 2 commits intokiwicom:masterfrom
devonwarren wants to merge 2 commits intokiwicom:masterfrom
Conversation
paveldedik
requested changes
Jul 18, 2024
Collaborator
There was a problem hiding this comment.
Hi @devonwarren thank you very much for the PR. After reading about stack_info, it looks good. Could you please:
- fix the mypy issue (see the Lint job error)
- add some tests for this? Would it be possible?
Thank you again for the contribution. And sorry that it took so long for me to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Utilize the
capture_internal_exceptionsfunction to send exceptions if thestack_infoflag is set so that the entire stack trace is captured in Sentry.event_from_exceptiondoes not support sending the entire stack (ref: getsentry/sentry-python#338)Closes #87