Conversation
- Reorder download options: direct → torrent → magnet → checksum - Add visual separation with margin and border before checksum section - Improve styling with icons, hover effects, and better spacing - Enhance UX with consistent button design and visual feedback Fixes kiwix#775
|
@yummyash Can you please put a screenshot in the description? |
- Reorder download options: direct → torrent → magnet → checksum - Add visual separation with margin and border before checksum section - Improve styling with icons, hover effects, and better spacing - Enhance UX with consistent button design and visual feedback Fixes kiwix#775
|
check the new one |
|
@yummyash Thx for your quick PR and for having improved a bit more than that. I like it I will assign reviewers and this will take a bit from now to gather feedbacks, maybe polish and merge. @rgaudin general review welcome |
|
hey @rgaudin @veloman-yunkan @siemsie can you please verify erarly as possible beacuse i want the confirmation mail as early as possible |
|
@yummyash thank you!
@kelson42 I saw the ticket requesting specifically the order change, I was surprised we're not pushing torrents first TBH. |
Yes, I didn't saw that at first look, but we should stick to the icon we had already chosen IMHO. At least for direct/bt/magnet. The lock is a symbol for security, IMO this is appropriate but I have no reference documentation to support my statement. |
In a way would make sense, but I still prefer to put HTTPS first because:
|
|
It's easier for me to draw something up based on what I see above and the feedback rather than leave a trail of notes/ideas. To be seen what width makes sense and what fits at what size (for example the SHA code)... We can take up a little more space on the screen... I suggest going a little more in this direction: |
| <script> | ||
| // Add functionality to checkboxes | ||
| document.addEventListener('DOMContentLoaded', function() { | ||
| const checkboxes = document.querySelectorAll('.option-checkbox'); | ||
|
|
||
| checkboxes.forEach(checkbox => { | ||
| checkbox.addEventListener('change', function() { | ||
| const link = this.closest('.download-option').querySelector('a'); | ||
| if (this.checked) { | ||
| link.style.opacity = '1'; | ||
| } else { | ||
| link.style.opacity = '0.6'; | ||
| } | ||
| }); | ||
|
|
||
| // Set initial state based on checkbox | ||
| const link = checkbox.closest('.download-option').querySelector('a'); | ||
| if (checkbox.checked) { | ||
| link.style.opacity = '1'; | ||
| } else { | ||
| link.style.opacity = '0.6'; | ||
| } | ||
| }); | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
This is contrary to the filename - this HTML page is supposed to be displayed in browsers not supporting Javascript.
I didn't review the rest of the code.
5 participants
Fixes kiwix/kiwix-tools#775