Fix VelocityPlugin to use proxyServer for server lookup#4
Closed
Conversation
Rewrite the `VelocityPlugin.java` file to use the `proxyServer` field for server lookup instead of the event. - Add `private final ProxyServer proxyServer` field to the `VelocityPlugin` class. - Update the constructor to accept a `ProxyServer` parameter and initialize the `proxyServer` field. - Replace `event.getServer().getServer()` with `proxyServer.getServer()` in the `onProxyInitialization` method. - Ensure the `proxyServer` field is used for server lookup in the `onPlayerJoin` method. - Remove unnecessary import of `java.io.File`. - Correct the logger statement in the `onPlayerJoin` method to include the player's username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the
VelocityPlugin.javafile to use theproxyServerfield for server lookup instead of the event.private final ProxyServer proxyServerfield to theVelocityPluginclass.ProxyServerparameter and initialize theproxyServerfield.event.getServer().getServer()withproxyServer.getServer()in theonProxyInitializationmethod.proxyServerfield is used for server lookup in theonPlayerJoinmethod.java.io.File.onPlayerJoinmethod to include the player's username.