Merged
Conversation
Update plugin to support unlimited lobbies and dynamic Minecraft versions. * Modify `HubCommand.java` and `LobbyCommand.java` to dynamically parse configuration keys for versions and lobby identifiers. * Implement load balancing among lobbies based on the fewest players connected. * Remove redundant logging for lobby configuration load in `HubCommand.java` and `LobbyCommand.java`. * Change protocol version retrieval to use a library in `HubCommand.java` and `LobbyCommand.java`. * Update `VelocityPlugin.java` to dynamically parse the configuration keys for versions and lobby identifiers. * Implement configuration validation and add a fallback mechanism to handle unavailable or misconfigured lobbies in `VelocityPlugin.java`. * Add logging to the console to ensure the config is understood and ensure the configuration is logged only once in `VelocityPlugin.java`. * Import `java.util.Comparator` to fix the error in `VelocityPlugin.java`. * Update `config.yml` to add a useful comment to help users add lobbies. * Change the plugin version to 2.0.0 in `gradle.properties`. * Update `README.md` to reflect the new configuration format, commands logic, load balancing strategies, and configuration validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update plugin to support unlimited lobbies and dynamic Minecraft versions.
HubCommand.javaandLobbyCommand.javato dynamically parse configuration keys for versions and lobby identifiers.HubCommand.javaandLobbyCommand.java.HubCommand.javaandLobbyCommand.java.VelocityPlugin.javato dynamically parse the configuration keys for versions and lobby identifiers.VelocityPlugin.java.VelocityPlugin.java.java.util.Comparatorto fix the error inVelocityPlugin.java.config.ymlto add a useful comment to help users add lobbies.gradle.properties.README.mdto reflect the new configuration format, commands logic, load balancing strategies, and configuration validation.