Reduce noisy "object has been modified" logs/events

[linkvt]

See knative/serving#15746

Changes

• 🧹 Reduce noisy logs/events containing "object has been modified" messages
  • Events are not recorded anymore and ERROR log messages were downgraded to DEBUG level.

/kind enhancement

Release Note

Reduce noisy logs/events containing "object has been modified" which are expected to happen from time to time during normal operation.
- Events were removed and ERROR log messages were downgraded to DEBUG level.

[linkvt]

/remove-approve

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.63%. Comparing base (5037c47) to head (885de40).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
controller/controller.go	33.33%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3289      +/-   ##
==========================================
+ Coverage   74.60%   74.63%   +0.02%     
==========================================
  Files         188      188              
  Lines        8184     8188       +4     
==========================================
+ Hits         6106     6111       +5     
  Misses       1839     1839              
+ Partials      239      238       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[linkvt]

Failed CI should be resolved as soon as knative/client#2101 is merged and propagated to the kn-plugin-admin repo.

[dprotaso]

Do we want to guard !c.workQueue.ShuttingDown() ? here

[linkvt]

Thanks that makes sense. I moved the shutdown check to the top, it shouldn't really affect the logic as the AddRateLimited functions (which call AddAfter) effectively also check that again, so it's more about avoiding useless error logs during shutdown.

pkg/vendor/k8s.io/client-go/util/workqueue/delaying_queue.go

Lines 249 to 253 in 7459906

	func (q *delayingType[T]) AddAfter(item T, duration time.Duration) {
	// don't add if we're already shutting down
	if q.ShuttingDown() {
	return
	}

[dprotaso]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment