Skip to content

[release-1.20] Skip disabling keep-alives when shutting down the webhook server #3305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Dec 24, 2025
Merged

[release-1.20] Skip disabling keep-alives when shutting down the webhook server #3305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,6 @@ func (wh *Webhook) Run(stop <-chan struct{}) error {
select {
case <-stop:
eg.Go(func() error {
// As we start to shutdown, disable keep-alives to avoid clients hanging onto connections.
server.SetKeepAlivesEnabled(false)

// Start failing readiness probes immediately.
logger.Info("Starting to fail readiness probes...")
drainer.Drain()
Expand Down
Loading