Skip to content

Add push notification support#340

Open
cdriehuys wants to merge 3 commits intodevelopfrom
feature/push-notifications
Open

Add push notification support#340
cdriehuys wants to merge 3 commits intodevelopfrom
feature/push-notifications

Conversation

@cdriehuys
Copy link
Member

@cdriehuys cdriehuys commented May 11, 2018

Closes #339

Proposed Changes

This PR adds support for push notifications. It adds endpoints related to management of push notification capable devices.

TODO

If your pull request is still a WIP, include a basic list of tasks that must be completed before the pull request should be considered.

  • Listing and registering of devices
  • Management of specific devices
  • Send notification on profile invitation

cdriehuys added 2 commits May 11, 2018 14:29
The view allows users to register new APNS devices and list existing
devices.
@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #340 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #340      +/-   ##
===========================================
+ Coverage    99.12%   99.13%   +<.01%     
===========================================
  Files           53       54       +1     
  Lines         1143     1150       +7     
  Branches        47       47              
===========================================
+ Hits          1133     1140       +7     
  Misses          10       10
Impacted Files Coverage Δ
km_api/notifications/urls.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e488504...ff3e344. Read the comment docs.

The view set provided by django-push-notifications does exactly what we
need, so we can ditch the custom views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant