fix(sidecar): resolve ReferenceError for 'addresses' in isSafeUrl proxy#366
Open
nightsale wants to merge 1 commit intokoala73:mainfrom
Open
fix(sidecar): resolve ReferenceError for 'addresses' in isSafeUrl proxy#366nightsale wants to merge 1 commit intokoala73:mainfrom
nightsale wants to merge 1 commit intokoala73:mainfrom
Conversation
The 'addresses' variable was defined with 'let' inside a try block, making it inaccessible at the final return statement. Moved the declaration outside the try block to fix local proxy crashes causing 'No news available' errors.
|
@nightsale is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addressesvariable was defined withletinside atryblock, makingit inaccessible at the final return statement. Moved the declaration outside
the try block to fix local proxy crashes causing 'No news available' errors.
Summary
The sidecar's
isSafeUrl()function threw a fatalReferenceError: addresses is not definedon every incoming request becauselet addresses = []wasscoped inside the
tryblock but referenced in the finalreturnstatementoutside it. This caused the local API server to crash in a loop, preventing
any RSS feed from being fetched on the desktop app.
Type of change
Affected areas
Checklist
api/rss-proxy.jsallowlist (if adding feeds)npm run typecheck)Screenshots
The sidecar logs before the fix (looping fatal crash):
[local-api] fatal ReferenceError: addresses is not defined at isSafeUrl (...local-api-server.mjs:200:43)Tested via the desktop executable (Windows
.exe) — the only contextwhere the sidecar runs. After the fix, the crash no longer appears in logs
and external feeds load correctly.