Skip to content

Comments

chore: update vscode devcontainer and fix tests in devcontainer#505

Open
KiTTYsh wants to merge 4 commits intokokonect-link:developfrom
KiTTYsh:devcontainer
Open

chore: update vscode devcontainer and fix tests in devcontainer#505
KiTTYsh wants to merge 4 commits intokokonect-link:developfrom
KiTTYsh:devcontainer

Conversation

@KiTTYsh
Copy link

@KiTTYsh KiTTYsh commented Oct 1, 2024

What

  • Remove devcontainer Dockerfile and use container directly from compose.yml
  • Bump devcontainer image version
  • Install ffmpeg during devcontainer initialization, change default devcontainer hostname to cherrypick.local
  • Add vscode launch/build shortcuts to vscode profile

Why

  • Removing Dockerfile removes unnecessary build operation
  • Keeping environment up to date speeds up dependency installation during devcontainer initialization
  • Ffmpeg and default hostname changes fix testing inside of devcontainer
  • Launch/build shortcuts for convenience

Additional info (optional)

Previous node devcontainer was built in 2023, and the proposed image was updated yesterday. The new image keeps the same NodeJS version.

These changes only affect the development environment in vscode, and do not change any project code or build artifacts.

Checklist

  • [✅] Read the contribution guide
  • [✅] Test working in a local environment
  • [❌] (If needed) Update CHANGELOG_CHERRYPICK.md
  • [❌] (If possible) Add tests

@KiTTYsh KiTTYsh force-pushed the devcontainer branch 7 times, most recently from a3fbd62 to dc64c72 Compare October 5, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant