This repository was archived by the owner on Dec 15, 2020. It is now read-only.
docker-compose QoL improvements #2319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I was also going to ask about updating the test images (to use newer operating systems / osquery versions), but I see there's already a convo about that here: #2239. |
nyanshak
force-pushed
the
docker-compose-updates
branch
from
4317da4 to
cb76089
Compare
* Allow users to specify addresses other than `host.docker.internal` for the `tls_hostname` in the example config.
* Using the current working directory can result in permissions issues if the UID / GID of the host don't match that of the mysql user in the container. Using a docker volume allows us to persist the data and avoid these permissions issues.
* Fixes kolide#2319 by allowing Linux users to add `extra_hosts` settings, which create an `/etc/hosts` entry for `host.docker.internal`.
nyanshak
force-pushed
the
docker-compose-updates
branch
from
cb76089 to
254b09b
Compare
zwass
approved these changes
Oct 9, 2020
Contributor
zwass
left a comment
zwass
left a comment
There was a problem hiding this comment.
Nice, thank you for this!
I tested in my macOS dev environment and everything works as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLEET_SERVER(fixes Can't start osqueryd test instances via docker-compose on Linux #2127) when using the docker-compose file to spin up multiple osquery clients