Skip to content

Conversation

@FlorianKirmaier
Copy link
Contributor

I've been working on my new jpro/javafx sample site www.jfx-ensemble.com and decided to add some bootstrapfx-samples as a starting point.

You can check out the samples with the following link: https://www.jfx-ensemble.com/?page=results/search/bootstrapfx

The PR contains a json-file that lists all samples and some preview images. I also slightly change the demo-project to be part of the release.
With this PR I should be able to add future versions of bootstrapfx to https://www.jfx-ensemble.com just by changing the version-number in the ensemble project.

Added als samples to the jfx-ensemble
@aalmiray
Copy link
Collaborator

Interesting proposition. I'm hesitant in publishing the sampler as it is right now, I'd prefer changing the artifact name to bootstrapfx-sampler. Also does the sampler jar have to be published to a remote Maven repository (Maven central or JCenter) or is it enough to just generate the POM and JAR for local consumption by jfx-ensemble?

Finally, I'd love to include samplers for other Kordamp projects such as Ikonli, JSilhouette, DesktopPaneFX 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants