adapter-utils and adapter-mybatis: update scope #koupleless/issues/425#59
adapter-utils and adapter-mybatis: update scope #koupleless/issues/425#59stbz4088 wants to merge 1 commit intokoupleless:mainfrom
Conversation
📝 WalkthroughWalkthroughMaven POM configuration updates across two modules: adding lombok as a provided dependency in koupleless-adapter-utils, adjusting scope declarations for build and test plugins, and adding jackson-databind as a test dependency in the mybatis adapter module. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
features/koupleless-adapter-utils/pom.xmlkoupleless-adapter-mybatis-3.5.15/pom.xml
🔇 Additional comments (2)
features/koupleless-adapter-utils/pom.xml (2)
22-26: Lombok configuration verified as correct.Lombok annotations (@DaTa, @builder) are used in
src/main/java/com/alipay/sofa/koupleless/adapter/thread/BizContext.java, and the version (1.18.30) is properly managed in the parent POM. Theprovidedscope is the correct approach for compile-time annotation processing.
30-30: Scope changes are correctly set and exclude these build/Maven dependencies from runtime.Both
koupleless-base-build-pluginandmaven-resolver-providerare appropriately scoped astest, which prevents them from being bundled in the runtime artifact. These are build/plugin-time dependencies, not runtime dependencies, making the test scope correct and aligned with the PR objective.
koupleless/koupleless#425

解决此问题,不必要的依赖不参与打包
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.