Skip to content

Comments

adapter-utils and adapter-mybatis: update scope #koupleless/issues/425#59

Open
stbz4088 wants to merge 1 commit intokoupleless:mainfrom
stbz4088:main
Open

adapter-utils and adapter-mybatis: update scope #koupleless/issues/425#59
stbz4088 wants to merge 1 commit intokoupleless:mainfrom
stbz4088:main

Conversation

@stbz4088
Copy link

@stbz4088 stbz4088 commented Jan 4, 2026

koupleless/koupleless#425
解决此问题,不必要的依赖不参与打包
image

Summary by CodeRabbit

  • Dependencies
    • Introduced new development-scoped dependency to enhance code generation capabilities in the adapter utilities module.
    • Enhanced testing infrastructure with data serialization support in the MyBatis adapter.
    • Updated existing dependencies with explicit test scope declarations to optimize the build environment.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 4, 2026

📝 Walkthrough

Walkthrough

Maven POM configuration updates across two modules: adding lombok as a provided dependency in koupleless-adapter-utils, adjusting scope declarations for build and test plugins, and adding jackson-databind as a test dependency in the mybatis adapter module.

Changes

Cohort / File(s) Summary
Adapter Utils Dependencies
features/koupleless-adapter-utils/pom.xml
Added lombok with provided scope; changed koupleless-base-build-plugin and maven-resolver-provider to test scope
MyBatis Adapter Dependencies
koupleless-adapter-mybatis-3.5.15/pom.xml
Added jackson-databind with test scope

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • gaosaroma
  • lvjing2

Poem

🐰 A rabbit hops through Maven's tweaking ground,
With lombok and Jackson dependencies found,
Scopes realigned to keep all tidy and neat,
Test and provided—the perfect treat!
Dependencies dancing in harmony's song 📦✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main changes: updating dependency scopes in adapter-utils and adapter-mybatis modules, which aligns with the primary objective of ensuring unnecessary dependencies are excluded from the package.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a4d433 and 9580fac.

📒 Files selected for processing (2)
  • features/koupleless-adapter-utils/pom.xml
  • koupleless-adapter-mybatis-3.5.15/pom.xml
🔇 Additional comments (2)
features/koupleless-adapter-utils/pom.xml (2)

22-26: Lombok configuration verified as correct.

Lombok annotations (@DaTa, @builder) are used in src/main/java/com/alipay/sofa/koupleless/adapter/thread/BizContext.java, and the version (1.18.30) is properly managed in the parent POM. The provided scope is the correct approach for compile-time annotation processing.


30-30: Scope changes are correctly set and exclude these build/Maven dependencies from runtime.

Both koupleless-base-build-plugin and maven-resolver-provider are appropriately scoped as test, which prevents them from being bundled in the runtime artifact. These are build/plugin-time dependencies, not runtime dependencies, making the test scope correct and aligned with the PR objective.

@stbz4088 stbz4088 changed the title adapter-utils: update scope #koupleless/issues/425 adapter-utils and adapter-mybatis: update scope #koupleless/issues/425 Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant