Also reject negative format values in APCuIterator#475
Open
TysonAndre wants to merge 1 commit intokrakjoe:masterfrom
Open
Also reject negative format values in APCuIterator#475TysonAndre wants to merge 1 commit intokrakjoe:masterfrom
TysonAndre wants to merge 1 commit intokrakjoe:masterfrom
Conversation
TysonAndre
force-pushed
the
format-negative
branch
from
8d0cd82 to
c5c06bd
Compare
Collaborator
|
Doesn't looks that this error condition is tested currently, add one? |
This would affect applications that accidentally or deliberately pass in negative values for $format (e.g. PHP_INT_MIN on 64-bit builds) The apc_error macro surprisingly calls php_verror, which is a fatal error. Switch this to zend_throw_error instead - this still supports PHP 8.0 so ValueError is too new.
TysonAndre
force-pushed
the
format-negative
branch
from
c5c06bd to
2e79183
Compare
Collaborator
|
Looks like apc_099.phpt is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would affect applications that accidentally or deliberately pass in negative values for $format (e.g. PHP_INT_MIN on 64-bit builds)