Example implementation of 1D curvilinear elements#180
Open
sbadrian wants to merge 1 commit intokrcools:masterfrom
Open
Example implementation of 1D curvilinear elements#180sbadrian wants to merge 1 commit intokrcools:masterfrom
sbadrian wants to merge 1 commit intokrcools:masterfrom
Conversation
Requires an updated CMS version! Some explanations: 1) Overall, the changes to the existing code are minimal. My understanding is that the way Sauter-Schwab works these days does not necessitate a swapping of the (control) vertices, instead we work with a reference element and basically remap the barycentric coordinates. I adapted the unit test for 1D Sauter-Schwab. I do not understand why I picked SauterSchwab as a reference for itself. Now I use the Gauss-Legendre. Of course, accuracy is low, but if something would go fundamentally wrong with the normal or the reordering of vertices I would expect it to be visible. 2) My 2D Mie series suffered from early convergence thus the rewrite. 3) The changes for lagrange.jl where necessary because the number of vertices of an element does not help to assess the type in the higher order case. (3 vertices can be a triangle or a quadratic segment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires an updated CMS version!
This is not yet to be merged, but it provides a BEAST version that allows to easily test the implementation of a 1D Curvilinear Mesh (see the sibling branch on CMS)!
Some explanations:
My understanding is that the way Sauter-Schwab works these days
does not necessitate a swapping of the (control) vertices,
instead we work with a reference element and basically remap the
barycentric coordinates.
I adapted the unit test for 1D Sauter-Schwab. I do not understand
why I picked SauterSchwab as a reference for itself. Now I use
the Gauss-Legendre. Of course, accuracy is low, but if something would
go fundamentally wrong with the normal or the reordering of vertices
I would expect it to be visible.
My 2D Mie series suffered from early convergence thus the rewrite.
The changes for lagrange.jl where necessary because the number of vertices
of an element does not help to assess the type in the higher order case.
(3 vertices can be a triangle or a quadratic segment)