new retrieve permissions working on "site" custom tag of events #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/jane/quakeml/plugins.py
Outdated
| negate = True | ||
| queryset = queryset.model.objects.get_filtered_queryset( | ||
| document_type="quakeml", queryset=queryset, negate=negate, | ||
| **kwargs) |
Collaborator
There was a problem hiding this comment.
you can filter also right here by appending your filter after get_filtered_queryset(), as this should return a QuerySet object itself - as long the queryset is not evaluated by looping over it you can continue to modify it like filtering, ordering etc.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I saw that, but I couldn't figure out how to invert the queryset at the end, so the only way I saw was to combine all these queries and invert them inside the SQL extra(where=..) query.
i.e. make the filter not return events that match all given criteria, but rather return events, that do not match the combination of given criteria. otherwise it is impossible to define a retrieve permission for a combination of two criteria (i.e. when user "does not have permission" to exclude events that match the given combination of criteria, e.g. exclude events at site X and below magnitude Y)
note that this needs krischer/django-plugins#11 to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..in order to filter out small events at certain sites. Based on #21. No need to merge in a hurry, pushing this mostly for visibility, as the motivating use case for #21.