Skip to content

Comments

Visualization integration#201

Merged
krishauser merged 54 commits intos2025from
sr_viz_main_clean
May 15, 2025
Merged

Visualization integration#201
krishauser merged 54 commits intos2025from
sr_viz_main_clean

Conversation

@Averyyy
Copy link
Collaborator

@Averyyy Averyyy commented May 12, 2025 •
edited
Loading

  • All features in the design doc have been implemented:
    • Includes 3D visualization of vehicles, pedestrians, traffic lights, and cones
    • Pedestrains & Cones tested with Parking team's ros bag, other object's definition are specified in Readme (for future perception team).
    • Also tested with Racing team
  • Integrated with GEMStack log format and log dashboard
  • Supports playback controls, multiple camera modes, and real-time rendering
  • Supports metric window showing & ROS bag visualization in feature request after first presentation
  • Performance meets all metrics
  • Readme file under sr-viz folder for future development
  • Fully tested and reviewed

main visualization:
https://github.com/user-attachments/assets/572666e5-513e-4723-84e6-1b426b4cf877
ros bag visualization:
https://github.com/user-attachments/assets/920120fd-b68f-4f0f-a6cc-c4feebfc29f5

Averyyy and others added 30 commits May 11, 2025 23:10
@Averyyy
feat: init srviz
6e807a9
@Jason717717 @Averyyy
create a simple scene with a road, cars, humans, and traffic lights
f7a34d1
@Jason717717 @Averyyy
change to finer models and try moving the vehicle
6100ed4
@Jason717717 @Averyyy
(feat): add follow camera mode and control for car movement
f1bc198
@Jason717717 @Averyyy
(feat): add pedestrian walking animation and switching cars for control
da11d5d
@Jason717717 @Averyyy
(feat): add support for initial headings of cars
a5d5ebf
@Jason717717 @Averyyy
disable context menu
1efcb00
@Jason717717 @Averyyy
add support for log replay
320e161
@Jason717717 @Averyyy
update readme
b872f5c
@Jason717717 @Averyyy
update readme
04c53c6
@Jason717717 @Averyyy
tmp
9572a3a
@Jason717717 @Averyyy
change to react and add support for scrubber
1912512
@Jason717717 @Averyyy
remove model
1e5cefd
@Jason717717 @Averyyy
correct gitignore
149ff47
@Jason717717 @Averyyy
style changes on scrubber
0cc18a1
@Jason717717 @Averyyy
disable context menu
4d32b40
@Shiyang-Zhao @Averyyy
Integrate with log_dashboard and add visualization of traffic lights …
63be881 
…and other vehicles
@Jason717717 @Averyyy
fix: make slider responsive
15b372e
@Jason717717 @Averyyy
fix: fix ground lines flickering
706ebf3
@Jason717717 @Averyyy
a little tweak on camera position
f06576c
@Shiyang-Zhao @Averyyy
fix build error
d056152
@Shiyang-Zhao @Averyyy
fix build error
10f1c4f
@Shiyang-Zhao @Averyyy
rollback
9d4d3a7
@Shiyang-Zhao @Averyyy
rollback
6b02613
@Shiyang-Zhao @Averyyy
fix models not rendered error in production
590fa4c
@Jason717717 @Averyyy
update requirements
c4f2d00
@Shiyang-Zhao @Averyyy
add traffic cones and show vehicle state
68c8f07
@Shiyang-Zhao @Averyyy
add traffic cones and show vehicle state
ab9dc45
@Jason717717 @Averyyy
feat: add support for viewing images and point cloud in rosbag
aead79f
@Jason717717 @Averyyy
feat: add a switch to turn on and off drag and zoom
2c8df9e
@Averyyy Averyyy requested a review from krishauser as a code owner May 12, 2025 21:31
github-advanced-security[bot]
github-advanced-security bot found potential problems May 12, 2025
View reviewed changes
krishauser
krishauser requested changes May 13, 2025
View reviewed changes
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no README for users to launch this visualizer, or for developers on how to manage the files in this folder. What does a developer need to have installed on their machine to edit the visualizer?

@Averyyy
Copy link
Collaborator Author

Averyyy commented May 13, 2025

There is no README for users to launch this visualizer, or for developers on how to manage the files in this folder. What does a developer need to have installed on their machine to edit the visualizer?

https://doc.clickup.com/9011960452/d/h/8cjf6m4-11871/0a1f074931900bb

And a corresponding readme is also added inside sr_viz/ folder

@Averyyy
Copy link
Collaborator Author

Averyyy commented May 14, 2025

There is no README for users to launch this visualizer, or for developers on how to manage the files in this folder. What does a developer need to have installed on their machine to edit the visualizer?

Hi professor:
we have polished our PR comment. Please have a look at the updated version. Thank you!

@Averyyy Averyyy changed the title Sr viz main clean Visualization integration May 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 15, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Jason717717 Jason717717 requested a review from krishauser May 15, 2025 10:04
krishauser
krishauser approved these changes May 15, 2025
View reviewed changes
Copy link
Owner

@krishauser krishauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krishauser krishauser merged commit 7f230d7 into s2025 May 15, 2025
1 of 4 checks passed
@krishauser krishauser deleted the sr_viz_main_clean branch May 15, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krishauser krishauser krishauser approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Averyyy @krishauser @Jason717717 @Shiyang-Zhao