Scroll to closest value and willChangeScaleValue() added #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a need to have notification BEFORE picker's value is gonna change
small refactoring on comparing the current value (is current == newValue -> no need to propagate the change)
scroll to closest value refactored -> now instead of need to set the EXACT value for picker if you wanna set it outside -> you can set the approximate you need and picker will scroll to closest corresponding (in my project i'm working on I need to set initial default values every time I load the view with the picker)
the project I'm using this in is located here: https://github.com/ronanamsterdam/capio/tree/_rz-picker
@kronik please take a look one have a chance. Thanks.