This repository was archived by the owner on Aug 7, 2024. It is now read-only.
26-27 lesson homework #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
|
krottv
suggested changes
May 21, 2022
| import retrofit2.Retrofit | ||
| import retrofit2.create | ||
|
|
||
| class ITunesRemoteDataSourceRetrofit : MusicApi { |
Owner
There was a problem hiding this comment.
Плохая практика. MusicApi должен быть отдельным интерфейсом, его не нужно реализовывать.
Нужно создать второй интерфейс DataSource. Да, так больше кода дублируется, но это правильный подход.
|
|
||
| @Serializable | ||
| data class Tracks( | ||
| var artist: String, |
Owner
There was a problem hiding this comment.
Модели данных нужно делать immutable - var.
| @Serializable | ||
| data class TracksModel( | ||
| var album: Album , | ||
| var tracks: ArrayList<Tracks> |
| private val _stateITunes = MutableStateFlow<List<AlbumModel>?>(null) | ||
| val stateITunes: StateFlow<List<AlbumModel>?> = _stateITunes | ||
|
|
||
| fun loadData() { |
| holder.imageAlbum.clipToOutline = true | ||
| holder.imageAlbum.outlineProvider = object: ViewOutlineProvider() { | ||
| override fun getOutline(p0: View, p1: Outline) { | ||
| p1.setRoundRect(0, 0, p0.width, p0.height, 10.0F) |
Owner
There was a problem hiding this comment.
Это почему у тебя скругления не как в фигме. Потому что в фигме они в DP, а ты указываешь в PX
| holder.titleTrack.text = item.title | ||
| holder.textTrack.text = item.artist | ||
|
|
||
| holder.imageTrack.clipToOutline = true |
Owner
There was a problem hiding this comment.
Для этого можно отдельную функцию придумать, чтобы не дублировать
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.